-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unix: add PthreadSigmask #138
Conversation
This PR (HEAD: beb6663) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/sys/+/434555 to see it. Tip: You can toggle comments from me using the |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/434555. |
Message from Ian Lance Taylor: Patch Set 1: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/434555. |
Message from Tobias Klauser: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/434555. |
Add a syscall wrapper for SYS_RT_SIGPROCMASK and export it as PthreadSigmask. The latter is defined by POSIX and can therefore be implemented by Darwin, etc. later on. Follow the approach used by Signalfd of passing _C__NSIG/8 as sigsetsize. This avoids exporting _C__NSIG and allows the syscall to work with the current definition of Sigset_t, which doesn't match the kernel definition of Sigset_t. Updates golang/go#55349
beb6663
to
295e0e8
Compare
This PR (HEAD: 295e0e8) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/sys/+/434555 to see it. Tip: You can toggle comments from me using the |
Message from Ian Lance Taylor: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/434555. |
Abandoning the PR since Github now messes up commit messages, see https://go-review.googlesource.com/c/sys/+/434555/1..2//COMMIT_MSG#b9 |
Message from Lorenz Power: Patch Set 2: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/434555. |
Add a syscall wrapper for SYS_RT_SIGPROCMASK and export it as PthreadSigmask. The latter is defined by POSIX and can therefore be implemented by Darwin, etc. later on.
Follow the approach used by Signalfd of passing _C__NSIG/8 as sigsetsize. This avoids exporting _C__NSIG and allows the syscall to work with the current definition of Sigset_t, which doesn't match the kernel definition of Sigset_t.
Updates golang/go#55349